D25449: Start of the new Formats KCM

[Tomaz Canabrava]

tcanabrava marked 23 inline comments as done.
tcanabrava added inline comments.

INLINE COMMENTS

> broulik wrote in kcm.cpp:37
> You're not importing this anywhere, and this still works? Makes me wonder why Qt went through the trouble of introducing this when it makes no diference over `qmlRegisterType<T>()` ...
> 
> Please also use a KCM-specific import name for this, such as `org.kde.private.kcms.formats`

I also don't know but now I have deprecated warnings on the terminal to change for that.

> davidedmundson wrote in localemodel.cpp:15
> c1 == QLocale::c()
> 
> might be better than comparing names?

old, unmodified code. Changing now.

> ervin wrote in localemodel.cpp:106
> This sounds like a std::find_if

it does, but the std::find_if has a worse readability than a for loop, at least for simple cases. I'm excited to be able to use ranges tougth.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D25449

To: tcanabrava, ervin, #vdg, #plasma, mart
Cc: mart, ngraham, broulik, ervin, davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200110/deb7a58b/attachment.html>