D26533: Add a logging category for the backend

Laurent Montel noreply at phabricator.kde.org
Thu Jan 9 06:14:26 GMT 2020


mlaurent requested changes to this revision.
mlaurent added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> CMakeLists.txt:14
>      TransactionSet.cpp
> +    libdiscover_backend_debug.cpp
>      pkui.qrc

Why adding it ? it's autogenerated so it's added by cmake directly

> CMakeLists.txt:30
> +add_library(DiscoverPackageKitNotifier MODULE PackageKitNotifier.cpp
> +    libdiscover_backend_debug.cpp
> +)

Why you add this file too ? it's autogenerated by ecm_qt_declare_logging_category and added directly

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D26533

To: meven, apol, ngraham, mlaurent
Cc: mlaurent, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200109/b31b9e7b/attachment.html>


More information about the Plasma-devel mailing list