D25375: Start of the accessibility KCM

[Tomaz Canabrava]

tcanabrava marked an inline comment as done.
tcanabrava added a comment.


  In D25375#575980 <https://phabricator.kde.org/D25375#575980>, @ervin wrote:
  
  > I think we discussed this already, but I'm not sure so before it gets lost... :-)
  >
  > Please consider using both key and name for your kcfg items, this allows to both respect the past storage format and provide nicer property names on the C++/QML side. Currently the storage used names are leaking to the internal API.
  
  
  Done.

INLINE COMMENTS

> cblack wrote in CMakeLists.txt:17
> What purpose does this serve? It looks like you're simply printing a list of source files with a Portuguese header.

stray debug. fixed.

> cblack wrote in kcmaccess.cpp:194
> You could consider using glib for a stable ABI instead of invoking a command line that could change at any time. Also would reduce dependencies for most distros, as glib's command line tools are often packaged separately from glib itself.

care to elaborate? This is old code and I haven't touched it.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D25375

To: tcanabrava, ngraham, ervin
Cc: cblack, ervin, ognarb, mart, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200108/7f78bea7/attachment.html>