D26389: DesktopPaths KCM: Move the settings logic to a KCoreConfigSkeleton class

[David Edmundson]

davidedmundson accepted this revision.
davidedmundson added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> desktoppathssettings.cpp:38
> +    {
> +        return QUrl::fromLocalFile(QDir::homePath() + QStringLiteral("/Desktop"));
> +    }

This doesn't seem right. If I'm running in French, I should surely have "Les Documents" or whatever.

But this does seem to match the current code...so I guess that's a task for another day

> globalpaths.cpp:152
> +    m_pathsSettings->setDefaults();
> +    m_pathsSettings->setDefaults();
>  

One of these duplicated lines can go

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D26389

To: ervin, #plasma, crossi, bport, meven, mart, davidedmundson
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200108/f09dc3ed/attachment-0001.html>