D26386: Kicker/RecentDocuments: add icons to actions

Méven Car noreply at phabricator.kde.org
Tue Jan 7 17:05:10 GMT 2020


meven planned changes to this revision.
meven added inline comments.

INLINE COMMENTS

> actionlist.cpp:62
>  
> +    if (!icon.isEmpty()) {
> +        map[QStringLiteral("icon")] = icon;

Remove this if

> recentcontactsmodel.cpp:93
>  
> -        actionList << Kicker::createActionItem(i18n("Show Contact Information..."), QStringLiteral("showContactInfo"));
> +        actionList << Kicker::createActionItem(i18n("Show Contact Information..."), QString(), QStringLiteral("showContactInfo"));
>  

Missing icon

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D26386

To: meven, #plasma, ngraham, hein
Cc: hein, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200107/153e8df8/attachment.html>


More information about the Plasma-devel mailing list