D25947: Add applet for controlling Night Color

[David Edmundson]

davidedmundson accepted this revision.
davidedmundson added a comment.


  Does it make sense to dump the C++ classes in libcolorcorrect?
  
  It has an import for use client side usage for the KCM, his is just another client, especially inhibitor.

INLINE COMMENTS

> main.qml:96
> +    Component.onCompleted: {
> +        if (KCMShell.authorize("kcm_nightcolor.desktop").length > 0)
> +            plasmoid.setAction("KCMNightColor", i18n("Configure Night Color..."), "configure");

I don't think we have an official QML coding guideline, but convention throughout plasma has been to put {} for single line if statements.

> main.qml:98
> +            plasmoid.setAction("KCMNightColor", i18n("Configure Night Color..."), "configure");
> +        plasmoid.removeAction("configure");
> +    }

Should

  plasmoid.removeAction("configure");

be in an else?

REPOSITORY
  R114 Plasma Addons

BRANCH
  nightcolor-applet

REVISION DETAIL
  https://phabricator.kde.org/D25947

To: zzag, #plasma, #vdg, ngraham, davidedmundson
Cc: davidedmundson, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200107/b0569444/attachment-0001.html>