D26401: KCM Baloo: Migrate to KConfigXT and add immutability

Benjamin Port noreply at phabricator.kde.org
Mon Jan 6 16:44:45 GMT 2020


bport added inline comments.

INLINE COMMENTS

> ervin wrote in filteredfoldermodel.cpp:59
> Indentation of that line and the previous one looks wrong... but surprisingly the previous line is not showing up as changed, I wonder if that's the review tool acting up.

No I just aligned with the previous "wrong" one

> ervin wrote in kcm.cpp:87
> Why are you updating m_previouslyEnabled again? The old code wasn't doing this AFAICT.

Because we need to update it:

- or we will not have same behavior if we enable / disable it with or without closing kcm between the two step

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D26401

To: bport, ervin, crossi, meven, #plasma
Cc: meven, crossi, ervin, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200106/b39ad6eb/attachment.html>


More information about the Plasma-devel mailing list