D26462: RFC: Register Secret Agent on startup

David Edmundson noreply at phabricator.kde.org
Mon Jan 6 12:21:17 GMT 2020


davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
Herald added a reviewer: jgrulich.
davidedmundson requested review of this revision.

REVISION SUMMARY
  Plasma NM's KDED is loaded on boot, but effectively does nothing until
  the relevant plasmoid triggers the KDED.
  
  This makes some sense for notifications and monitors, as it allows a
  user to opt of a UI plasma network manager experience.
  
  However, we want the secret agent as early in the boot as possible.
  If a user is running NM, they definitely want this component active, and
  if NM isn't running then registering the agent will no-op anyway.
  
  DBus logs show that with this patch, I am retrieving my password and
  a full 1500ms before org.kde.plasmanetworkmanagement.init is called and my initial wifi
  connected 3s faster than before this patch.
  
  We could potentially move this kded to phase 0 and get us even earlier.

TEST PLAN
  Had a wifi with security set to "Store password for this user only"
  Added dbus-monitor into my startup scripts
  
  Logged in, wifi connected, logs showed a difference

REPOSITORY
  R116 Plasma Network Management Applet

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D26462

AFFECTED FILES
  kded/service.cpp

To: davidedmundson, #plasma, jgrulich
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200106/bfbc647f/attachment.html>


More information about the Plasma-devel mailing list