D26447: Dynamically show and hide based on whether or not any vaults are configured
Nathaniel Graham
noreply at phabricator.kde.org
Sun Jan 5 23:35:17 GMT 2020
ngraham created this revision.
ngraham added reviewers: broulik, ivan, Plasma, VDG.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ngraham requested review of this revision.
REVISION SUMMARY
Currently, the Vaults icon is always visible in the System Tray. However most tray icons
dynamically show and hide themselves based on whether or not they're relevant and in use,
which results in a nice clean clutter-free System Tray. So it would be nice for Vaults
to do the same.
This patch implements that behavior by adding a `count` property that gets updated based
on vault creation and deletion, and making the icon only appear in the tray when the count
is greater than 0. People who prefer to have it always visible can of course override
this in the System Tray settings, but the auto-hide behavior in this patch is probably a
better default for most.
TEST PLAN
1. Have no vaults -> icon is only in the popup
2. Create a vault -> icon appears in the tray
3. Delete the vault -> icon disappears from the tray and lives in the popup again
REPOSITORY
R845 Plasma Vault
BRANCH
dynamically-show-and-hide (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D26447
AFFECTED FILES
plasma/package/contents/ui/main.qml
plasma/vaultsmodel.cpp
plasma/vaultsmodel.h
To: ngraham, broulik, ivan, #plasma, #vdg
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200105/acb976ef/attachment.html>
More information about the Plasma-devel
mailing list