D26445: [KRunner KCM] Mark KCM as dirty when plugin configuration changes
Kai Uwe Broulik
noreply at phabricator.kde.org
Sun Jan 5 20:18:43 GMT 2020
broulik created this revision.
broulik added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.
REVISION SUMMARY
Connect `configCommitted` to ensure "Apply" gets enabled when you change any of the runner plugin settings.
Also, clean up the other connect.
TEST PLAN
- Connecting to `dirty` insted of `markAsDirty` so it can go into 5.17
- Opened KCM, opened dictionary runner settings, changed keyword, "Apply" not got enabled as expected
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D26445
AFFECTED FILES
kcms/runners/kcm.cpp
To: broulik, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200105/dceed16f/attachment-0001.html>
More information about the Plasma-devel
mailing list