D26275: SourcesPage: Override contentItem of ListSectionHeader instead of relying on data property
Arjen Hiemstra
noreply at phabricator.kde.org
Sun Jan 5 13:13:15 GMT 2020
ahiemstra abandoned this revision.
ahiemstra added a comment.
> The bug mentioned got fixed by this (old Qt doesn't iterate over QList).
>
> I don't see how this would make it look any different. The kirigami visible patch is indeed necessary but for an entirely different reason.
You're right, it does seem to work correctly now. Weird, when I made this I was sure the problem was with the sizing of the ActionToolBar. But maybe I was put off by the overflow button visibility.
REPOSITORY
R134 Discover Software Store
REVISION DETAIL
https://phabricator.kde.org/D26275
To: ahiemstra, #plasma, #discover_software_store, apol, ngraham
Cc: rikmills, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200105/297ea2c2/attachment.html>
More information about the Plasma-devel
mailing list