D26434: [Battery Monitor] Don't blink when battery is critical

Kai Uwe Broulik noreply at phabricator.kde.org
Sun Jan 5 13:04:13 GMT 2020


broulik created this revision.
broulik added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  Especially when you're almost out of juice you don't want to be wasting it blinking an icon causing excess repaints.
  Also considering the critical percentage is hardcoded to 5% here and doesn't follow PowerDevil's setting.
  Given battery critical notification is persistent and always on top of everything these days, you can't really miss the fact that you're almost ouf of power.

TEST PLAN
  - Fully charged: was hidden still
  - Not fully charged: was active now, never blinked, even when low

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D26434

AFFECTED FILES
  applets/batterymonitor/package/contents/ui/batterymonitor.qml

To: broulik, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200105/496d3fbd/attachment.html>


More information about the Plasma-devel mailing list