D26425: [Notifications KCM] Fixup current item syncing logic

[Kai Uwe Broulik]

broulik created this revision.
broulik added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  Instead of relying on `currentIndex` and some massively complicated logic to track when the index didn't change but the item behind that index, just use `currentItem`.
  The `updateCurrentIndex` being called during model changes massively confused `ListView` leading to inconsistent view state.
  
  BUG: 410842
  FIXED-IN: 5.18.0

TEST PLAN
  - Selecting apps by clicking and arrow keys still works
  - Filtering keeps the view on the right in sync with whatever happens to be selected in the list on the left
  - I didn't notice any broken or missing entries in the list anymore

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D26425

AFFECTED FILES
  kcms/notifications/package/contents/ui/SourcesPage.qml

To: broulik, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200104/9b8c7f84/attachment.html>