D26421: Only show full name in review dialog

Nathaniel Graham noreply at phabricator.kde.org
Sat Jan 4 21:39:38 GMT 2020


ngraham created this revision.
ngraham added reviewers: Discover Software Store, apol.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  The review gets submitted with your full name, but the review dialog currently shows
  both the full name and username. This patch removes the username display so that it shows
  the actual name string that will be used.

TEST PLAN
  Before: F7860875: Before.png <https://phabricator.kde.org/F7860875>
  After: F7860874: After.png <https://phabricator.kde.org/F7860874>

REPOSITORY
  R134 Discover Software Store

BRANCH
  full-name-only (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26421

AFFECTED FILES
  libdiscover/appstream/OdrsReviewsBackend.cpp

To: ngraham, #discover_software_store, apol
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200104/58f1c2fa/attachment.html>


More information about the Plasma-devel mailing list