D26418: [Applet]Add global mute function

[Nathaniel Graham]

ngraham added a comment.


  Code looks sane enough except for one thing:

INLINE COMMENTS

> main.qml:659
>  
> +    // Wait for paSinkModel init.
> +    Timer {

This makes me nervous. How do we know it will have initialized after 200 ms? Is there an `onFinished` signal we can listen for or something? Could we make one?

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D26418

To: gvgeo, #vdg, #plasma, drosca
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200104/6a6f77e8/attachment.html>