D26271: [Applet]Update layout based on T10470

[George Vogiatzis]

gvgeo marked 7 inline comments as done.
gvgeo added a comment.


  About the devices labels, I feel it is fine as it is. It is not a problem, to have two devices with the same port name.
  Only if could put a tooltip. But no, Radiobutton does not deserve a tooltip.
  What else to do, without displaying the full device names?
  
  I took a look at breeze, for the lines between list items and coloring and tab changes. I was lost and didn't know, what I was looking for exactly.
  I will keep an eye, but... I feel this will be part of a more general breeze evolution.
  By the time I will have decode how theme system works, it is possible that you will have already made the changes.

INLINE COMMENTS

> main.qml:407
>  
> -                    Header {
> -                        Layout.fillWidth: true
> -                        visible: sourceOutputView.count > 0 && !streamsView.simpleMode
> -                        text: i18n("Recording Streams")
> +                    PlasmaCore.SvgItem {
> +                        elementId: "horizontal-line"

This is the line that separates the playback and recording applications.
Just notice that should not always be visible. Will fix.

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D26271

To: gvgeo, #vdg, #plasma, manueljlin, drosca
Cc: filipf, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200104/efc5c3ab/attachment.html>