D26379: [KCMs/Notifications] Tweak layout and strings to have a bit more visual grouping for the logical sections

Nathaniel Graham noreply at phabricator.kde.org
Fri Jan 3 03:35:23 GMT 2020


ngraham added a comment.


  The indentation here was done to be consistent with the other one, but the reason why they're indented is to make it clear that they're a part of the logical group of controls that's "introduced" by the first left label in the formlayout section. Ideally every section has only a single one of these labels that stands in as a sort of pseudo-header for the whole section. I'm not super happy with the two groups in this layout that have two left labels, but I couldn't figure out a way to get rid of them without removing options.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  section-grouping-in-notifications-kcm (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26379

To: ngraham, broulik, #plasma, #vdg
Cc: ndavis, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200103/c23c72e5/attachment-0001.html>


More information about the Plasma-devel mailing list