D26344: Fix building plasma-desktop without X11 cursor development headers

[Johan Ouwerkerk]

ouwerkerk added a comment.


  Right now the KCM CmakeListst does stuff like:
  
    set(kcm_lookandfeel_SRCS
      kcmmain.cpp
      kcm.cpp
      ../krdb/krdb.cpp
      ../cursortheme/xcursor/cursortheme.cpp
      ../cursortheme/xcursor/xcursortheme.cpp
    )
  
  And the main `kcm.cpp` simply includes cursor deps without `#ifdef`. 
  It's not impossible to rework that so all the cursor related setters/getters are effectively hidden behind `#ifdef` however, so the question becomes: do we want that? I.e. do we genuinely want to use the lookandfeel KCM on platforms without mouse cursors?
  
  Otherwise it is a lot less work to go for the easy solution of making X11 cursor dependencies mandatory if we want to ensure the lookandfeel KCM is always built.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D26344

To: ouwerkerk, #plasma, davidedmundson
Cc: davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200101/9be85750/attachment.html>