D27702: Block calls to org.kde.KSplash till it is registered

David Edmundson noreply at phabricator.kde.org
Thu Feb 27 14:27:30 GMT 2020


davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
davidedmundson requested review of this revision.

REVISION SUMMARY
  A recent update to startup made it too fast and hit a race with ksplash.
  
  We expose that we could send that kinit and ksmserver were ready before
  ksplash registered the service name.
  
  We have an existing mechanism to make DBus server queue up messages if a
  service is not registered yet without actually activating it. So we can
  re-use that.
  
  Long term we need to rethink ksplash completely.

TEST PLAN
  Confirmed issue with extra debug
  Logged in and the issue was gone

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27702

AFFECTED FILES
  startkde/waitforname/CMakeLists.txt
  startkde/waitforname/org.kde.KSplash.service.in

To: davidedmundson, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200227/089b5df2/attachment.html>


More information about the Plasma-devel mailing list