D27698: Fix PrivateActionToolButton behaviour with showText vs IconOnly

[Arjen Hiemstra]

ahiemstra created this revision.
ahiemstra added a reviewer: Kirigami.
Herald added a project: Kirigami.
Herald added a subscriber: plasma-devel.
ahiemstra requested review of this revision.

REVISION SUMMARY
  PrivateActionToolButton behaves slightly different when setting
  showText to false versus setting display to IconOnly. This is
  because the implicitWidth binding does not check the display
  property. This fixes that to make sure both `showText: false`
  and `display: IconOnly` return the implicitHeight, making the
  button square in both cases.

TEST PLAN
  Kirigami Gallery still works correctly.

REPOSITORY
  R169 Kirigami

BRANCH
  patb_icononly_width

REVISION DETAIL
  https://phabricator.kde.org/D27698

AFFECTED FILES
  src/controls/private/PrivateActionToolButton.qml

To: ahiemstra, #kirigami
Cc: plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, ahiemstra, davidedmundson, mart, hein
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200227/fe8aa863/attachment.html>