D27380: [GTK Config] Construct font style by hand instead of relying on Qt function

[Mikhail Zolotukhin]

gikari added a comment.


  In D27380#618545 <https://phabricator.kde.org/D27380#618545>, @IlyaBizyaev wrote:
  
  > In D27380#618531 <https://phabricator.kde.org/D27380#618531>, @ngraham wrote:
  >
  > > The problem being solved here is that starting with 5.18, style names were being localized, which GTK doesn't understand, causing it to fall back to the default font. This patch fixes that.
  >
  >
  > I see :)
  >  I just thought maybe the pre-existing solution from the deleted KCM could be reused since it seemed to work well.
  
  
  I literally copied the font construction algorithm from GTK KCM. May be the font, that was passed from the Qt Widgets picker was different.
  
  In D27380#618518 <https://phabricator.kde.org/D27380#618518>, @ngraham wrote:
  
  > However I know what @davidedmundson is going to say: "Working around Qt bugs requires a code comment mentioning the Qt bug report." :) So let's add that.
  >
  > Also I could not find a bug report in https://gitlab.gnome.org/GNOME/gtk/issues about this issue of GTK3 ignoring the font style. Can you file one?
  
  
  So, I need to mention two bug reports: Qt one and GTK one. And should I create both of them? In case of GTK everything is somewhat clear, but in case of Qt I do not even know what to report (or how to do that correctly, or where it is broken): font picker just gives you a font with style name in local language, which is correctly applied for Qt applications, but not for GTK ones.

REPOSITORY
  R99 KDE Gtk Configuration Tool

REVISION DETAIL
  https://phabricator.kde.org/D27380

To: gikari, #plasma, ervin, bport, meven, davidedmundson
Cc: chauvin, davidre, davidedmundson, cfeck, ngraham, IlyaBizyaev, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200226/e5613724/attachment.html>