D27685: Remove extra top and bottom padding from dock widgets

Nathaniel Graham noreply at phabricator.kde.org
Wed Feb 26 20:07:39 GMT 2020


ngraham created this revision.
ngraham added reviewers: VDG, Breeze.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  This extra padding was no big deal when using the current Breeze style, where scrollable
  views float amorphously over the background with no clearly-defined edges, but becomes
  highly noticeable in a bad way when moving towards enclosing views between single-pixel
  lines, as for T11661 <https://phabricator.kde.org/T11661>. In this case, you want for the scrollview to touch the line.

TEST PLAN
  (With D27669 <https://phabricator.kde.org/D27669> also applied) Dolphin's Places panel, before: F8133813: Before.png <https://phabricator.kde.org/F8133813>
  
  After: F8133812: After.png <https://phabricator.kde.org/F8133812>
  
  Doesn't look any worse without D27669 <https://phabricator.kde.org/D27669> applied either.

REPOSITORY
  R31 Breeze

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27685

AFFECTED FILES
  kstyle/breezestyle.cpp

To: ngraham, #vdg, #breeze
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200226/08576c42/attachment-0001.html>


More information about the Plasma-devel mailing list