D27650: ItemContainer: disconnect signals in destructor

[David Edmundson]

davidedmundson added a comment.


  > No, AFAIK I don't have commit access.
  
  Ok, well I hope this is the first of many patches. I like working with people who can use gdb!
  
  Good stuff.

INLINE COMMENTS

> alnikiforov wrote in itemcontainer.cpp:68
> Should I remove these 2 disconnects or leave them as they are?

Lets get rid of them. Then it helps self-document that this the one left is doing something explicitly for a good reason.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27650

To: alnikiforov, ngraham, davidedmundson, mart
Cc: anthonyfieroni, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200226/8974ac89/attachment.html>