D27664: Improve layout and appearance of app details view
Nathaniel Graham
noreply at phabricator.kde.org
Tue Feb 25 21:45:34 GMT 2020
ngraham created this revision.
ngraham added reviewers: VDG, Discover Software Store, apol.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ngraham requested review of this revision.
REVISION SUMMARY
After porting to FormLayout in D27183 <https://phabricator.kde.org/D27183>, the layout can now be so wide due to the URLs
that it switches to the compact/mobile view. This patch re-arranges things a bit and
uses human-readable strings for the links instead of showing raw URLs. For safety,
this requires D27663 <https://phabricator.kde.org/D27663> to be implemented first.
BUG: 418019
FIXED-IN: 5.19.0
Depends on D27663 <https://phabricator.kde.org/D27663>
TEST PLAN
Before: normal-sized window (shows the compact/mobile view): F8131970: Before.png <https://phabricator.kde.org/F8131970>
Before wide window: F8131971: Before 2.png <https://phabricator.kde.org/F8131971>
After: normal-sized or wide window: F8131972: After.png <https://phabricator.kde.org/F8131972>
REPOSITORY
R134 Discover Software Store
BRANCH
clean-up-app-details (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D27664
AFFECTED FILES
discover/qml/ApplicationPage.qml
To: ngraham, #vdg, #discover_software_store, apol
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200225/76d2382a/attachment-0001.html>
More information about the Plasma-devel
mailing list