D27638: allow to take qqc2 actions and fix issues with it not having the visible prop

Aleix Pol Gonzalez noreply at phabricator.kde.org
Tue Feb 25 17:42:04 GMT 2020


apol added inline comments.

INLINE COMMENTS

> ActionToolBar.qml:211
>              id: button
> +            visible: true
>              flat: root.flat && !kirigamiAction.icon.color.a

Isn't visible true by default?

> ActionToolBarLayoutDetails.qml:138
>          PrivateActionToolButton {
> +			visible: true
>              flat: details.flat && !kirigamiAction.icon.color.a

Indentation is broken.

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D27638

To: camiloh, ahiemstra, mart
Cc: apol, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, ahiemstra, davidedmundson, mart, hein
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200225/c00f680e/attachment.html>


More information about the Plasma-devel mailing list