D27100: [GTK Config] Parameterise GTK config editing
Carson Black
noreply at phabricator.kde.org
Tue Feb 25 16:38:08 GMT 2020
cblack requested changes to this revision.
cblack added a comment.
This revision now requires changes to proceed.
There's a lot of string concatenation going on. I would replace a lot of the instances where you concat more than 2 strings with QString's arg function for readability purposes.
Will review more thoroughly when I get the time.
REPOSITORY
R99 KDE Gtk Configuration Tool
REVISION DETAIL
https://phabricator.kde.org/D27100
To: gikari, #plasma, cblack
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200225/714691af/attachment.html>
More information about the Plasma-devel
mailing list