D27626: refactor: fix various compiler warnings

[Daniel Vrátil]

dvratil added a comment.


  A good rule of a thumb is that your move constructor and assignment operator should always be `noexcept` unless you have a very good reason for them not to be. Qt has most move constructors marked as noexcept - I found a few that are not marked but that looks more like an oversight rather than intent, more so that Qt does not use exceptions - so if you have a type composed Qt types, making the constructor `noexcept` is perfectly safe. For custom types, even if their move constructors/assignment operators are not marked as `noexcept` it's fairly safe to assume they do not throw since we generally do not use exceptions in KDE.

REPOSITORY
  R104 KScreen

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27626

To: dvratil, #plasma, romangg
Cc: romangg, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200225/6e0013af/attachment.html>