D27650: Don't use guarded pointers for AppletsLayout

[David Edmundson]

davidedmundson requested changes to this revision.
davidedmundson added a comment.
This revision now requires changes to proceed.


  > This function takes a plain pointer and wraps it into weak shared pointer.
  
  That's QWeakPointer.
  
  QPointer is something else that doesn't have an equivalent in stdlib.
  It takes a QObject,  then QObject has a special hook to unset watching QPointers to nullptr in QObject::~QObject()
  
  I don't understand how this could fix anything.
  
  If this is null, then m_layout is dangling which is worse.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27650

To: alnikiforov, ngraham, davidedmundson, mart
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200225/9138f917/attachment.html>