D27651: Fixes for applet configuration layout.

George Vogiatzis noreply at phabricator.kde.org
Tue Feb 25 14:23:10 GMT 2020


gvgeo created this revision.
gvgeo added reviewers: Plasma, VDG.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
gvgeo requested review of this revision.

REVISION SUMMARY
  Fix applet configuration overlap with top line.
  Change the margins to move scrollbar so that it touches the edge,
  and use margins for content.
  Change the layout so that categories column can get the full height.
  Remove 2 unused properties.
  Fix bind loop for pageFlickable's width.

TEST PLAN
  Open desktop and audio configurations and make windows small.
  Select audio category and move content to the top. (If there is no
  scrollbar, increase and decrease height to exploit bug.)
  Before:
  At the right side (the main) scrollbar will have a margin.
  Desktop categories stop above buttons cancel, ok.
  Main content, and category highlight are displayed on top of the line.
  After:
  Scrollbar touch the edge, and the content has correct margin.
  Categories height is not limited.
  Main content, and category highlight touch the line below.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  configscollcat (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27651

AFFECTED FILES
  desktoppackage/contents/configuration/AppletConfiguration.qml

To: gvgeo, #plasma, #vdg
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200225/ed751e24/attachment.html>


More information about the Plasma-devel mailing list