D27629: [plasma-session] Load startup and shutdown on demand

[Aleix Pol Gonzalez]

apol accepted this revision.
apol added a comment.
This revision is now accepted and ready to land.


  +1 patch makes sense to me overall.

INLINE COMMENTS

> startplasma.cpp:396
>  
> -    if (exitCode == 255) {
> -        // Startup error
> -        messageBox(QStringLiteral("startkde: Could not start ksmserver. Check your installation.\n"));
> -        return false;
> -    }
> -    return true;
> +    startPlasmaSession.start(QStringLiteral(CMAKE_INSTALL_FULL_BINDIR "/plasma_session"), plasmaSessionOptions);
> +    e.exec();

You might want to check if start() returns an error.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27629

To: davidedmundson, #plasma, apol
Cc: apol, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200224/a819d4a5/attachment.html>