D27480: Solid-device-automounter/kcm: Get rid of singleton for AutomounterSettings

Méven Car noreply at phabricator.kde.org
Mon Feb 24 14:06:04 GMT 2020


meven added inline comments.

INLINE COMMENTS

> ervin wrote in DeviceAutomounter.cpp:111
> This is rather odd. A too eager search and replace? ;-)

Thanks indeed

> ervin wrote in AutomounterSettings.cpp:23
> I guess you could have used `using AutomounterSettingsBase::AutomounterSettingsBase;` in the header instead.

Nice suggestion

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27480

To: meven, ervin, crossi, bport, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200224/23491a01/attachment.html>


More information about the Plasma-devel mailing list