D27380: [GTK Config] Construct font style by hand instead of relying on Qt function
Kevin Ottens
noreply at phabricator.kde.org
Mon Feb 24 11:11:42 GMT 2020
ervin added a comment.
A minor style nitpick, otherwise LGTM. As mentioned by the author, this likely require extensive testing before going in.
INLINE COMMENTS
> configvalueprovider.cpp:53
>
> +QString ConfigValueProvider::fontStyleHelper(const QFont& font) const
> +{
Space should be before & not after
REPOSITORY
R99 KDE Gtk Configuration Tool
REVISION DETAIL
https://phabricator.kde.org/D27380
To: gikari, #plasma, ervin, bport, meven, davidedmundson
Cc: chauvin, davidre, davidedmundson, cfeck, ngraham, IlyaBizyaev, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200224/876acd83/attachment.html>
More information about the Plasma-devel
mailing list