D27595: Watch for language change events, and forward those to the QML engine

Volker Krause noreply at phabricator.kde.org
Sun Feb 23 12:40:32 GMT 2020


vkrause created this revision.
Herald added a project: Kirigami.
Herald added a subscriber: plasma-devel.
vkrause requested review of this revision.

REVISION SUMMARY
  This fixes a race condition on startup for the Kirigami translation
  catalog that happens as follows:
  
  - QML code triggers the loading of the Kirigami plugin
  - the ECM QM loader is triggered, but since this is running outside of the
  
  main thread, the actual QM loading is deferred to the main thread
  
  - QML code execution continues, at which point qsTr might still return
  
  unstranslated strings
  
  This is for example visible by the "Actions" header in the context drawer
  of the main application page not getting translated.

REPOSITORY
  R169 Kirigami

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27595

AFFECTED FILES
  src/kirigamiplugin.cpp
  src/kirigamiplugin.h

To: vkrause
Cc: plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, ahiemstra, davidedmundson, mart, hein
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200223/70ddbfe5/attachment.html>


More information about the Plasma-devel mailing list