D27556: HiDPI pixmap

[Yunhe Guo]

guoyunhe marked 2 inline comments as done.
guoyunhe added inline comments.

INLINE COMMENTS

> apol wrote in AuthDialog.cpp:108
> You should get the dpr from the window, not the qApp. Different screens will have different dprs.

Fixed. Getting it from widget now.

> apol wrote in AuthDialog.cpp:133
> All are integers, why are you turning it into QPointF?

This is how HiDPI QPainter works.

Source https://doc.qt.io/qt-5/highdpi.html#migrate-existing-applications

> Always use the qreal versions of the QPainter drawing API.

REPOSITORY
  R121 Policykit (Polkit) KDE Agent

REVISION DETAIL
  https://phabricator.kde.org/D27556

To: guoyunhe, #plasma
Cc: anthonyfieroni, apol, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200222/919c2701/attachment-0001.html>