D27566: WebShortcuts Runner: Refactor foreach, remove unnecessary method
Alexander Lohnau
noreply at phabricator.kde.org
Sat Feb 22 06:54:53 GMT 2020
alex created this revision.
alex added reviewers: ngraham, broulik, meven, apol.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
alex requested review of this revision.
REVISION SUMMARY
The foreach has been refactored and the loadSyntaxes method gets now called directly.
Additionally the cached (failed) key/provider can be reused for multiple sessions and is only cleared when the config changes.
TEST PLAN
Should compile and open urls as before.
REPOSITORY
R120 Plasma Workspace
BRANCH
webshortcuts_cleanup (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D27566
AFFECTED FILES
runners/webshortcuts/webshortcutrunner.cpp
runners/webshortcuts/webshortcutrunner.h
To: alex, ngraham, broulik, meven, apol
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200222/3bf25992/attachment-0001.html>
More information about the Plasma-devel
mailing list