D27537: Fix simpleWrite test in kwaylandbackendtest

Roman Gilg noreply at phabricator.kde.org
Fri Feb 21 13:12:38 GMT 2020


romangg added a comment.


  Thanks, but the commit message in wrong as the type must be `test` since this is a fix to an autotest. And the scope `autotest` does not exist. See https://cgit.kde.org/libkscreen.git/tree/CONTRIBUTING.md
  
  Also the header is not very expressive. A "fix" can be everything and the kitchen sink.
  
  I will revert the commit and if you would like to recommit I would recommend the header:
  
  `test: query correct output`

REPOSITORY
  R110 KScreen Library

REVISION DETAIL
  https://phabricator.kde.org/D27537

To: dvratil, #plasma, romangg
Cc: romangg, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200221/3a7a3b89/attachment.html>


More information about the Plasma-devel mailing list