D27380: [GTK Config] Construct font style by hand instead of relying on Qt function

[Lionel Chauvin]

chauvin added inline comments.

INLINE COMMENTS

> configvalueprovider.cpp:50
> +    const QString fontStyle = fontStyleHelper(font);
> +    return font.family() + QStringLiteral(", ") + fontStyle + ' ' + QString::number(font.pointSize());
>  }

I think

  QStringLiteral(", ")

should be replaced by a space (see my comment <https://bugs.kde.org/show_bug.cgi?id=333146#c8>)

however I don't know what will happen in ambigious cases such like:
"DejaVu Sans" + " " + "Condensed Bold" + " " +"11"
and
"DejaVu Sans Condensed" + " " + "Bold" + " " +"11"

REPOSITORY
  R99 KDE Gtk Configuration Tool

REVISION DETAIL
  https://phabricator.kde.org/D27380

To: gikari, #plasma, ervin, bport, meven, davidedmundson
Cc: chauvin, davidre, davidedmundson, cfeck, ngraham, IlyaBizyaev, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200220/bf3dda8b/attachment-0001.html>