D27513: Kill Runner: Remove duplicate function calls and refactor
Aleix Pol Gonzalez
noreply at phabricator.kde.org
Thu Feb 20 14:31:35 GMT 2020
apol added a comment.
Seems to me like there's 2 very different changes here, can you split in 2 reviews?
INLINE COMMENTS
> CMakeLists.txt:20
> +set(krunner_kill_SRCS killrunner.cpp)
> add_library(krunner_kill MODULE ${krunner_kill_SRCS})
> target_link_libraries(krunner_kill
just pass it to add_library
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D27513
To: alex, davidedmundson, ngraham, broulik, meven
Cc: apol, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200220/60d08363/attachment.html>
More information about the Plasma-devel
mailing list