D27521: Various fixes to make autotests run and pass

[Arjen Hiemstra]

ahiemstra created this revision.
ahiemstra added a reviewer: Kirigami.
Herald added a project: Kirigami.
Herald added a subscriber: plasma-devel.
ahiemstra requested review of this revision.

REVISION SUMMARY
  Apparently Kirigami's autotests have not run for a while. This
  patch fixes that and makes some other changes so the tests pass
  again and in the future it should be easier to add tests.
  
  Changes:
  
  - Move add_subdirectory(autotests) to a location where BUILD_TESTING is defined so we actually can add the dir.
  - Add each test QML file as a separate test so reports are generated per test and tests can be run individually.
  - Add an autotest to test creation and rendering of Icon.
  - Fix most of the existing tests by making sure the window they rely on actually gets shown.
  - Fix PageRow test by changing it to matching current behaviour of PageRow.

TEST PLAN
  With this, "make test" should work and pass.

REPOSITORY
  R169 Kirigami

BRANCH
  autotest_fixes

REVISION DETAIL
  https://phabricator.kde.org/D27521

AFFECTED FILES
  CMakeLists.txt
  autotests/CMakeLists.txt
  autotests/tst_icon.qml
  autotests/tst_keynavigation.qml
  autotests/tst_listskeynavigation.qml
  autotests/tst_pagerow.qml
  src/CMakeLists.txt

To: ahiemstra, #kirigami
Cc: plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, ahiemstra, davidedmundson, mart, hein
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200220/ee1f0d8c/attachment.html>