D27518: Only enable the "Help" button if khelpcenter is available

Ahmad Samir noreply at phabricator.kde.org
Thu Feb 20 13:06:02 GMT 2020


ahmadsamir created this revision.
ahmadsamir added a reviewer: Plasma.
Herald added a project: Plasma.
ahmadsamir requested review of this revision.

REVISION SUMMARY
  Use a static const bool to check if khelpcenter is available on the
  system, so as not to check every time a module is opened.
  
  BUG: 400602

TEST PLAN
  - make sure khelpcenter is not installed and open systemsettings
  - navigate to any module (one that has Help visible, e.g. Fonts), "Help" button is disabled
  - install khelpcenter and restart systemsettings, the "Help" button should be enabled

REPOSITORY
  R124 System Settings

BRANCH
  l-khelp (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27518

AFFECTED FILES
  core/ModuleView.cpp

To: ahmadsamir, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200220/f2b66c05/attachment.html>


More information about the Plasma-devel mailing list