D27495: Remove unnecessary code and function calls

[David Edmundson]

davidedmundson added a comment.


  Cleanup is good.
  
  > Futhermore the match icon and the list of actions can be reused.
  
  I don't think these changes really bring anything.
  Icon's are cached at the layer beneath (with a proper QCache with expunging) and actionsForMatch is called so rarely that doing:
  
    return actions().values();
  
  Will be just as performant in practical terms.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  shellrunner_cleanup

REVISION DETAIL
  https://phabricator.kde.org/D27495

To: alex, davidedmundson, ngraham, broulik, meven, #plasma
Cc: meven, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200220/5120792b/attachment.html>