D27514: Fix incorrect use of case statements in accountmodel.cpp

Bernhard Rosenkraenzer noreply at phabricator.kde.org
Thu Feb 20 00:19:46 GMT 2020


bero updated this revision to Diff 76032.
bero added a comment.


  Probably best to just add a comment explaining what needs to be done if AccountModel::* roles ever diverge from DisplayRole/DecorationRole...
  
  Leaving the code the way it is now will result in a harder to trace error if Qt ever changes the values of DisplayRole or DecorationRole (and may give people looking at the code bad ideas), revising it the way I proposed earlier causes duplicate case values.

REPOSITORY
  R128 User Manager

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27514?vs=76031&id=76032

REVISION DETAIL
  https://phabricator.kde.org/D27514

AFFECTED FILES
  src/lib/accountmodel.cpp

To: bero, #plasma, davidedmundson
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200220/1f759062/attachment.html>


More information about the Plasma-devel mailing list