D27513: Kill Runner: Remove duplicate function calls and refactor

Alexander Lohnau noreply at phabricator.kde.org
Wed Feb 19 19:58:54 GMT 2020


alex created this revision.
alex added reviewers: davidedmundson, ngraham, broulik, meven.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
alex requested review of this revision.

REVISION SUMMARY
  Duplicate function calls to load the config in the runner/config have been removed.
  Additionally the config keys/sorting enum have been moved to a new file, before this the runner included the header of the config class.
  The actions of the runner are also refactored, similar to https://phabricator.kde.org/D3688.
  Also the user (owner of process) has been removed from the subtext, because the second line is not shown and adding the user info to the same line would be too long.

TEST PLAN
  Should compile and kill processes as before.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  killrunner_cleanup (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27513

AFFECTED FILES
  runners/kill/CMakeLists.txt
  runners/kill/config_keys.h
  runners/kill/killrunner.cpp
  runners/kill/killrunner.h
  runners/kill/killrunner_config.cpp
  runners/kill/killrunner_config.h

To: alex, davidedmundson, ngraham, broulik, meven
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200219/921bc9d1/attachment.html>


More information about the Plasma-devel mailing list