D27505: Do not crash when icon's width or height is 0

Arjen Hiemstra noreply at phabricator.kde.org
Wed Feb 19 17:38:31 GMT 2020


ahiemstra added a comment.


  In D27505#614240 <https://phabricator.kde.org/D27505#614240>, @davidedmundson wrote:
  
  > Would be good to dump this test qml somewhere in the repo. A folder full of tests which just have one component in a bunch of configurations.
  >  I've been pushing for that in p-f, and it catches so many things.
  
  
  Actually, it should be possible to test this as part of the autotests. However, I just found out that the Kirigami autotests are broken and have not run for a pretty long time. So I will make a separate patch for that.

REPOSITORY
  R169 Kirigami

BRANCH
  icon_crash

REVISION DETAIL
  https://phabricator.kde.org/D27505

To: ahiemstra, #kirigami, davidedmundson
Cc: ngraham, davidedmundson, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, apol, ahiemstra, mart, hein
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200219/67230be4/attachment.html>


More information about the Plasma-devel mailing list