D27495: Remove unnecessary code and function calls
Alexander Lohnau
noreply at phabricator.kde.org
Wed Feb 19 08:03:45 GMT 2020
alex created this revision.
alex added reviewers: davidedmundson, ngraham, broulik.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
alex requested review of this revision.
REVISION SUMMARY
The ShellConfig class has been deleted. This config class was in KDE4 for the runOptions widget used and the class/the settings are not used anymore.
Additionally the context type check has been removed, because this is already solved using the ignore types.
Futhermore the match icon and the list of actions can be reused.
TEST PLAN
Should compile and execute shell commands as before.
REPOSITORY
R120 Plasma Workspace
BRANCH
shellrunner_cleanup
REVISION DETAIL
https://phabricator.kde.org/D27495
AFFECTED FILES
runners/shell/CMakeLists.txt
runners/shell/shellOptions.ui
runners/shell/shell_config.cpp
runners/shell/shell_config.h
runners/shell/shellrunner.cpp
runners/shell/shellrunner.h
To: alex, davidedmundson, ngraham, broulik
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200219/89776cf0/attachment-0001.html>
More information about the Plasma-devel
mailing list