D27422: [KCM]Update Device item layout based on applet

[David Edmundson]

davidedmundson added inline comments.

INLINE COMMENTS

> DeviceListItem.qml:32
>      id: delegate
> +    spacing: units.smallSpacing * 2
>      width: parent.width

Kirigami.Units.smallSpacing please

(for all units in KCM code)

again, for complex reasons, sorry.

> DeviceListItem.qml:106
> +        spacing: units.smallSpacing
> +        Layout.preferredWidth: parent.width
> +

Do you need this?

It should be the same as Layout.fillWidth which will be on by default for a layout in a layout

REPOSITORY
  R115 Plasma Audio Volume Applet

BRANCH
  kcmports2

REVISION DETAIL
  https://phabricator.kde.org/D27422

To: gvgeo, #plasma, drosca, ngraham, #vdg
Cc: davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200218/ed9c50f5/attachment.html>