D27408: Fix build with Qt 5.15.0

Laurent Montel noreply at phabricator.kde.org
Tue Feb 18 15:24:46 GMT 2020


mlaurent added a comment.


  In D27408#613565 <https://phabricator.kde.org/D27408#613565>, @ngraham wrote:
  
  > @mlaurent ^^
  
  
  Just a question: How I can see it if nobody adds me as reviewer (if I remember I was the only one guys who works against qt5.15 from several months so why don't add me as reviewer ? )? (For sure I have some scripts for automate theses changes so I commit quickly it)
  
  but this patch was wrong as QOverload<int, const QString&>::of(&QComboBox::currentIndexChanged), was created in qt5.15 not in "<= qt5.15" so in qt5.15.1 it will failed when  we compile without deprecated methods.

REPOSITORY
  R121 Policykit (Polkit) KDE Agent

REVISION DETAIL
  https://phabricator.kde.org/D27408

To: apol, #plasma
Cc: ngraham, mlaurent, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200218/8c5044c3/attachment.html>


More information about the Plasma-devel mailing list