D27472: [plasma-session] Cleanup StartServiceJob

Aleix Pol Gonzalez noreply at phabricator.kde.org
Tue Feb 18 12:10:08 GMT 2020


apol accepted this revision.
apol added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> startup.cpp:438
> -
> -    connect(p, &QProcess::errorOccurred, this, [this] (QProcess::ProcessError error) {
> -        qCWarning(PLASMA_SESSION) << "error on process" << error << m_process << m_args;

Are you sure showing an error message on error is not useful anymore?

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27472

To: davidedmundson, #plasma, apol
Cc: apol, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200218/441333ae/attachment.html>


More information about the Plasma-devel mailing list