D27052: Solid-device-automounter/kcm: Convert some foreach

Méven Car noreply at phabricator.kde.org
Mon Feb 17 16:24:17 GMT 2020


meven added inline comments.

INLINE COMMENTS

> ervin wrote in DeviceAutomounter.cpp:73
> nitpick, feel free to ignore: would make sense to switch to a const ref here since we're touching the line anyway. in the same vein, "const auto" on the line before wouldn't be a bad idea either (if we ever switch to QVector for instance it'd be one less place where compilation would break).

Unfortunately this is not possible line 78 requires a non-const ref to volume.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  arcpatch-D27052_1

REVISION DETAIL
  https://phabricator.kde.org/D27052

To: meven, broulik, ervin, #plasma
Cc: alex, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200217/929fe4d2/attachment.html>


More information about the Plasma-devel mailing list