D27442: fix(kcm): Use explicit Kirigami.Units over singleton from a theme

David Edmundson noreply at phabricator.kde.org
Sun Feb 16 19:27:53 GMT 2020


davidedmundson added a comment.


  > More generally, should we be porting towards Kirigami.Units everywhere?
  
  "everywhere" is complex.
  
  If it was using the API from kirigami's theme plugin, it should be ported.
  If it was resolving against the one from PlasmaCore, that's fine.

REPOSITORY
  R104 KScreen

BRANCH
  Plasma/5.18

REVISION DETAIL
  https://phabricator.kde.org/D27442

To: davidedmundson, #plasma, apol
Cc: davidre, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200216/a54f99ee/attachment-0001.html>


More information about the Plasma-devel mailing list